Suspicious code in kdebase 3.5.2

[Lubos Lunak]

On Saturday 08 April 2006 10:43, Ismail Donmez wrote:
> Hi Christoph,
> Cumartesi 8 Nisan 2006 11:21 tarihinde, Christoph Bartoschek şunları
> yazmıştı: [...]
>
> > - kwin/utils.cpp:313
> >
> > !(*dot = 0) is  always true and therefore unneccessary. Or do you mean
> > !(*dot ==0)?
>
> Indeed, fixed.

 No, that's an obscurism coming from I don't even remember where. Reverted.

> [...]
...
> [...]
>
> > - kcontrol/crypto/crypto.cpp:1980
> >
> > cr is allocated with operator new[] use delete []
>
> Fixed.

 As far as I can tell you haven't committed a single of these changes to 
trunk, do you intend to do so? We have enough code in 3.5.x that's not in 
trunk already, no need to make it even worse :(.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/