Suspicious code in kdebase 3.5.2

Brad Hards bradh at
Sat Apr 8 11:34:45 BST 2006

On Saturday 08 April 2006 18:21 pm, Christoph Bartoschek wrote:
> - kcontrol/input/logitechmouse.cpp:56
> m_usbDeviceHandle is a pointer and therefore 0 cannot be bigger than
> m_usbDeviceHandle
Yes. usb_open() returns NULL on error, not a negative int (like every other 
call in libusb).

I don't have a KDE 3.5 with which to test this, but it should read:
    if ( 0 == m_usbDeviceHandle ) {

If that compiles, please commit it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <>

More information about the kde-core-devel mailing list