Suspicious code in kdebase 3.5.2

[Thiago Macieira]

Christoph Bartoschek wrote:
>Am Samstag, 8. April 2006 10:43 schrieb Ismail Donmez:
>> > This while(1) loop can be executed at most once.
>>
>> Why?
>
>Because each path you choose in this loop lets it break.  There is no
> continue in the loop and the last command is return Tok_str;

The whole point is to be able to break. It's like an enhanced goto.

But it should be a do { ... } while(0); loop so as to not confuse people.
-- 
Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
  thiago.macieira (AT) trolltech.com     Trolltech AS
    GPG: 0x6EF45358                   |  Sandakerveien 116,
    E067 918B B660 DBD1 105C          |  NO-0402
    966C 33F5 F005 6EF4 5358          |  Oslo, Norway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060408/7ab51488/attachment.sig>