KAction name parameter: ok to change from const char to QString?

Hamish Rodda rodda at kde.org
Thu Apr 6 14:38:05 BST 2006


I'm porting kdebase to not depend on KAccel + KKeyNative + friends, and I'm 
noticing that KShortcutList used to use a QString for shortcut names.

In order to port these uses to KAction / KActionCollection, it would be better 
to use QString for action names as well (i.e. replacing the const char* name 
parameter for KAction with const QString&, and updating other methods to 
suit).  To me this makes sense, because the name is stored as a QString 
anyway.  Also, we can have KActions with utf encoded names, so non-latin1 
programmers should be happy.

Does this sound ok?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060406/6a760eee/attachment.sig>

More information about the kde-core-devel mailing list