KAction name parameter: ok to change from const char to QString?

[Michaël Larouche]

Le Jeudi 6 Avril 2006 09:38, Hamish Rodda a écrit :
> Hi,
>
> I'm porting kdebase to not depend on KAccel + KKeyNative + friends, and I'm
> noticing that KShortcutList used to use a QString for shortcut names.
>
> In order to port these uses to KAction / KActionCollection, it would be
> better to use QString for action names as well (i.e. replacing the const
> char* name parameter for KAction with const QString&, and updating other
> methods to suit).  To me this makes sense, because the name is stored as a
> QString anyway.  Also, we can have KActions with utf encoded names, so
> non-latin1 programmers should be happy.
>
> Does this sound ok?
>
> Cheers,
> Hamish.

Sounds good for me, QObject::setObjectName take a QString now anyway.
-- 
Michaël Larouche (Shock The Dark Mage)
KDE developer working on Kopete, Kamefu...on dial-up :P
--------------------------------------
Blog: http://mlarouche.blogspot.com/
MSN/Email: michael.larouche at kdemail.net
IRC: irc.freenode.org/DarkShock on #kopete,#solid,#kamefu,#plasma
Jabber: darkshock at myjabber.net