[PATCH] "close" action shortcut

Thomas Zander zander at kde.org
Sat Dec 3 08:36:51 GMT 2005

On Saturday 03 December 2005 00:36, Jarosław Staniek wrote:
> FIX1. win32 only:
> CTRL+F4 shortcut is well known and expected to work on win32: added it
> as default shortcut; CTRL+W moved as alternative.
> FIX2. After FIX1, "close_window" action in KMDI can just use
> KStdAccel::close()
> OK to commit?

I'm not one to object; but I do want to get off my chest that platform 
defaults being ifdefed in sourcecode is not really a proper solution in 
my mind.

Don't we already have ways to do this without touching the sources? I'd 
hate to see the same functionality implemented twice in two different 
ways. (making one useless, or worse)
Thomas Zander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20051203/92be7376/attachment.sig>

More information about the kde-core-devel mailing list