[PATCH] "close" action shortcut

[Nicolas Goutte]

On Saturday 03 December 2005 21:35, Jarosław Staniek wrote:
> Nicolas Goutte said the following, On 2005-12-03 20:27:
> > On Saturday 03 December 2005 20:25, Jarosław Staniek wrote:
> >>Nicolas Goutte said the following, On 2005-12-03 19:17:
> >>>On Saturday 03 December 2005 19:13, Jaroslaw Staniek wrote:
> >>>>Gary Cramblitt said the following, On 2005-12-03 00:57:
> >>>>>On Friday 02 December 2005 06:36 pm, Jarosław Staniek wrote:
> >>>>>>A patch for 3.5.1 and trunk:
> >>>>>>
> >>>>>>FIX1. win32 only:
> >>>>>>CTRL+F4 shortcut is well known and expected to work on win32: added
> >>>>>> it as default shortcut; CTRL+W moved as alternative.
> >>>>>>
> >>>>>>FIX2. After FIX1, "close_window" action in KMDI can just use
> >>>>>>KStdAccel::close()
> >>>>>
> >>>>>I have no problem with the patch but just wanted to mention that if
> >>>>> you go into K Control Center | Regional and Accessibility | Keyboard
> >>>>> Shortcuts, and choose the Windows theme, Ctrl+F4 is already assigned
> >>>>> to File | Close.
> >>>>
> >>>>OK, thanks for the hint. Now I decided to give up with altering
> >>>> KStdAccel and instead alter default kdeglobals file:
> >>>>
> >>>>[Shortcuts]
> >>>>Close=Ctrl+F4;Ctrl+W
> >>>>
> >>>>Please could anyone tell me: is there a template for (global, not
> >>>> user's) kdeglobals file created somewhere by KDE scripts?
> >>>>If not, I guess we will keep such a template in win/ subdir so one day
> >>>> it can be added to our official KDE/win32 package.
> >>>
> >>>But people using Linux would perhaps want Windows key bindings too. So I
> >>>do not understand why you do not want to add it to the normal key
> >>>bindings, especially that as far as I see, it is already there.
> >>>
> >> > (I really doubt that a
> >>>
> >>>Windows user will want to select the KDE key bindings, except if he
> >>> knows KDE beforehand.)
> >>
> >>CTRL+W is there already on windows used in some apps, e.g. in Mozilla.
> >> It's all about sane defaults.
> >
> > Then perhaps it should be added as alternative in the files below. (Also
> > that the user can get back the default for Windows, if he wants to try
> > other key bindings.)
>
> See the attached patch. OK? (also added cut/copy/paste alternatives since
> these are still available/used on win32)

Looks good for me!