desktop/kicker + icon placement

[David Faure]

On Monday 08 August 2005 12:43, Martin Koller wrote:
> On Tuesday 28 June 2005 10:28, David Faure wrote:
> > On Tuesday 28 June 2005 10:23, Dirk Mueller wrote:
> > > On Tuesday 19 November 2024 14:05, Martin Koller wrote:
> > > > Does anything speak against simply not resizing the workarea in this
> > > > cases
> >
> > I thought we had fixed workarea problems, and that the new reason for the
> > bug was that lineupIcons isn't idempotent, i.e. any time lineupIcons is
> > called, icons move (e.g. up) instead of staying in place when they are
> > grid-aligned already.
> > (see my comment on http://bugs.kde.org/show_bug.cgi?id=47627)
> 
> I don't see this as the problem.

Well it's another problem that happened on top of the one[s] you fixed.
It can be seen by the fact that every time a panel was shown/hidden, i.e.
lineupicons was called, the icons would move *up*. Not "up when showing,
down when hiding", as one would have expected.
We need a DCOP call for lineupicons to be able to call it by hand and check
what it does - right now it's only called when something happens, which can
be a bit more difficult to trigger I think.

> I now have solved this and other bugs by introducing a dcop-kicker method 
> which allows to request the free space on the desktop not covered by any 
> panel - even if the panel is hidden.
> I checked this with Aaron and have already commited the kicker modifications.

Excellent.

> Regarding this I also had to modify the desktop a bit, e.g. to no longer store 
> the icon positions in a relative-to-the-iconArea way (as on startup I do not 
> know the iconArea and this relative-storing was ugly at all), but simply in 
> absolute coordinates. During this, I also solved the problem, that on 
> desktopResize (XRANDR) the icons did not recover their resolution dependent 
> position.
> 
> Attached you find the patch.
> Is it ok to commit ?

Yes, please do. Thanks a lot.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).