desktop/kicker + icon placement

[Martin Koller]

On Tuesday 28 June 2005 10:28, David Faure wrote:
> On Tuesday 28 June 2005 10:23, Dirk Mueller wrote:
> > On Tuesday 19 November 2024 14:05, Martin Koller wrote:
> > > Does anything speak against simply not resizing the workarea in this
> > > cases
>
> I thought we had fixed workarea problems, and that the new reason for the
> bug was that lineupIcons isn't idempotent, i.e. any time lineupIcons is
> called, icons move (e.g. up) instead of staying in place when they are
> grid-aligned already.
> (see my comment on http://bugs.kde.org/show_bug.cgi?id=47627)

I don't see this as the problem. The bug is, that the grid-align feature acts 
on the iconArea set in KDIconView which was always changing when the 
KWinModules workArea changed. As Aaron said, we need an area for icons 
independent from the workArea.

I now have solved this and other bugs by introducing a dcop-kicker method 
which allows to request the free space on the desktop not covered by any 
panel - even if the panel is hidden.
I checked this with Aaron and have already commited the kicker modifications.

Now clearly there has to be changes in desktop.
I made the following changes:

As the problem with the icon position on relogin + grid-auto-align is due to 
the fact that kicker starts after kdesktop, I had to introduce the following:
desktop asks kicker via DCOP for the desktopIconsArea. If there is no response 
during 2 seconds and the desktop is currently initializing, I start a timer 
with 15 seconds max. timeout.
During that time, I do not align the icons on the grid, but when kicker tells 
me the iconArea, I stop the timer (or if there is no kicker, I still have the 
timer firing, which would then lead to getting the desktops size).


Regarding this I also had to modify the desktop a bit, e.g. to no longer store 
the icon positions in a relative-to-the-iconArea way (as on startup I do not 
know the iconArea and this relative-storing was ugly at all), but simply in 
absolute coordinates. During this, I also solved the problem, that on 
desktopResize (XRANDR) the icons did not recover their resolution dependent 
position.

Attached you find the patch.
Is it ok to commit ?

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

       Some operating systems are called 'user friendly',
             Linux however is 'expert friendly'.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdesktop.patch
Type: text/x-diff
Size: 19149 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050808/101da84d/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050808/101da84d/attachment.sig>