Supermount handling in KMountPoint

[Gustavo Pichorim Boiko]

On Friday 15 October 2004 12:54, David Faure wrote:
> On Friday 15 October 2004 15:39, Gustavo Pichorim Boiko wrote:
> > Hi
> >
> > I've done a small patch to fix supermount handling in KMountPoint
> > Supermount doesn't use the device name in the specified field of
> > fstab/mtab. Instead, it puts "none" on this field. The device name is
> > specified in the mount options.
> >
> > Please review the patch and tell me if it is ok.
>
> Looks ok. Please use "const QStringList&" for the argument to the new
> method, and a ConstIterator instead of Iterator in its implementation.

Thanks for the hint. I've fixed it and commited to CVS.

> kio/global.cpp might need a similar fix, but that's another story.

I guess it needs a fix like that. I'm going to take it a look when I have 
time.

> OTOH one might wonder why anyone needs KMountPoint to show supermount-ed
> directories. Those don't need Type=Device .desktop files to be
> mounted/unmounted, and KMountPoint is mostly used in the property dialog
> for device .desktop files, no? (no objection to the patch, just wondering
> where the class is used)

Well, Kévin has already answered your question :)

Both the media:/ and devices:/ use KMountPoint to get current and possible 
mount points.

Cheers
-- 
Gustavo Pichorim Boiko
----------------------------------------
gustavo.boiko @ kdemail . net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20041015/15136f75/attachment.sig>