Patch for KEditToolbar dnd support

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun May 16 2004 02:28, Sandro Giessl wrote:
> Hello,
>
> Would anyone mind reviewing the following patch? It adds drag&drop
> support to KEditToolbarWidget.
> http://sandro.giessl.com/files/kedittoolbar_dnd.diff
>
> Sorry, it's quite long. Basically what it does is:
> - Replace the KListViews with a subclass enabled for dnd using a custom
> QStoredDrag subclass.
> - Move the private list view mmbers to the d pointer, but keeps the old
> members. This hopefully keeps binary compatibility.

I don't think this is needed, you can just change the type of the private 
members. They are private so they can't be used by anyone outside the class 
itself anyway and the size of the members will remain the same (because they 
remain pointers).

> Especially why I'm CCing to kde-core-devel is because I'm unsure about
> the DragObject stuff. For example, is it ok to simply choose a random
> "data/x-kde.toolbar.item" mime type name for the toolbar item data or
> is there anything to consider when creating a new mime type?

No, that should be just fine.

Cheers,
Waldo
- -- 
bastian at kde.org  |   Novell BrainShare Europe 2004   |  bastian at suse.com
bastian at kde.org  | 12-18 September, Barcelona, Spain |  bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFAp3AON4pvrENfboIRAgd8AKCbQVhI+nGkq3MsMGQntbO/Ylo0QgCfenCI
sWrNsTfK3IwkE3vSpxgC3nI=
=tyIs
-----END PGP SIGNATURE-----