createStandardKWindow()

[Benjamin Meyer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 07 June 2004 2:48 pm, David Faure wrote:
> On Monday 07 June 2004 20:38, Benjamin Meyer wrote:
> > Much better and smaller name :)  Those changes and I moved the new
> > functions into KMainWindow in this new patch.
>
> You can remove the "TODO modal" ... KEditToolbar _is_ modal (default value
> true for modal argument to KDialogBase constructor).
> Ah. But you should use exec() instead of show().

yes it is modal, but it shouldn't be.  Why should it block the application?  
Currently it doesn't even let you if you wanted to.  Every app in kdeui 
should let you if you want to (i.e. the dev forgot to put it in the 
constructor)

> KNotifyDialog is a problem. You can't use it from kdeui, it's in libkio.
> I think you have to drop the Notifications item completely, unfortunately.

:(  True, where could we put the function in kio to make life easier?

> > if( actionCollection()->count() > 0 ){
>
> should be !actionCollection()->isEmpty(). But in fact KEditToolBar will
> find all actions from the guiFactory, not only from KMainWindow, so I
> think the test is incorrect, I suggest removing it.

Yah, ok, updated (and smaller) diff attached.

- -Benjamin Meyer

- -- 
Public Key: http://www.csh.rit.edu/~benjamin/public_key.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAxNkw1rZ3LTw38vIRAupSAJ9+Om6ojpaFohqiCqV0TZIqBndfxgCdH/9s
qg4Lx6PSeeJb7kiBCN6BT4w=
=9k/Z
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff
Type: text/x-diff
Size: 4516 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040607/0089718d/attachment.diff>