[PATCH] Fix Bug 73029 (after upgrade to 3.2 knotify keeps spawning artsds and prevents KDE from starting)

Ingo Klöcker kloecker at kde.org
Thu Jan 22 19:42:31 GMT 2004


the following quite trivial patch fixes this bug. But this patch doesn't 
fix the general problem which is that during the execution of slot 
restartedArtsd()  the restartedServer() signal can be emitted. Obviously 
this leads to an infinite loop. Connecting the slot to the signal after 
the explicite call to restartedArtsd() prevents the infinite loop which 
prevented my KDE from starting up, but this code is seriously in need of 
some more fixing because infinite looping is still possible.

Index: knotify/knotify.cpp
RCS file: /home/kde/kdelibs/arts/knotify/knotify.cpp,v
retrieving revision 1.88
diff -u -3 -p -r1.88 knotify.cpp
--- knotify/knotify.cpp 30 Oct 2003 14:12:25 -0000      1.88
+++ knotify/knotify.cpp 22 Jan 2004 10:30:24 -0000
@@ -219,8 +219,8 @@ KNotify::KNotify( bool useArts )
     d->audioManager = 0;
     if( useArts )
-        connect( soundServer, SIGNAL( restartedServer() ), this, SLOT( restartedArtsd() ) );
         restartedArtsd(); //started allready need to initialize d->audioManager
+        connect( soundServer, SIGNAL( restartedServer() ), this, SLOT( restartedArtsd() ) );

     d->volume = 100;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040122/b2cf23f9/attachment.sig>

More information about the kde-core-devel mailing list