andy at athame.co.uk
Sun Jan 11 17:39:27 GMT 2004
On Sunday 11 January 2004 16:31, David Leimbach wrote:
> On Jan 11, 2004, at 7:57 AM, Tobias Koenig wrote:
> > On Sun, Jan 11, 2004 at 02:40:53PM +0100, Antonio Larrosa Jiménez
> > wrote:
> >> El Domingo 11 Enero 2004 13:59, Stephan Kulow escribió:
> > Hi,
> >>>> I was wondering if it would be acceptable to add a DragonFly
> >>>> directory
> >>>> to the kdeabase/ksysguard/ksysguardd/ directory hierarchy?
> >>> Definitly not. You're late by _months_
> >> David, that's just another way of saying that you're too fast by three
> >> weeks :) . I'm quite sure your patches will be accepted after 3.2 is
> >> released, which is planned for the 2nd of February (although that's
> >> something the ksysguard mantainer should say).
> > Well, IIRC I'm the maintainer of ksysguard. I've no BSD system here for
> > testing, so I'd have to trust David anyway that his patch works.
> > Nevertheless the RD has the last word, and since Coolo said no, I'd
> > also prefer to apply the patch after the 3.2 release.
> I've already applied them though. See my discussion with Andy Fawcett
> in kde-devel.
I tried Dave's patches on FreeBSD, since he decided that it was easier to
tweak the DragonFly build to follow the FreeBSD path, and there were no
ill-effects. The changes were made in FreeBSD-specific code, and won't affect
any other platform.
> None of the patches are outside of a __DragonFly__ ifdef so they
> shouldn't affect anything in FreeBSD or otherwise.
Yep, everything was nicely wrapped for conditional compilation.
> If the patches aren't working you should know right away because the
> code won't compile on your system as all the changes involved using
> DragonFly specific data structures.
Tobias, feel free to send FreeBSD questions|problems to kde at freebsd.org, and
we will endeavour to maintain that part of the codepath for you. I'll try to
monitor any changes you make in the !FreeBSD paths, and make the necessary
changes for FreeBSD. Hopefully Dave will do the same for DragonFly.
I'm not entirely sure that the differences between DragonFly and FreeBSD
warrant a separate directory, possibly it would be better to tweak the
configure logic to let DragonFly follow the FreeBSD directory, and make
conditional changes in there.
Andy Fawcett | andy at athame.co.uk
| tap at kde.org
"In an open world without walls and fences, | tap at lspace.org
we wouldn't need Windows and Gates." -- anon | tap at fruitsalad.org
More information about the kde-core-devel