Patch for kabc resources

Holger Freyther freyther at
Tue Jan 6 16:15:38 GMT 2004

On Tuesday 06 January 2004 17:04, Tobias Koenig wrote:
> On Tue, Jan 06, 2004 at 02:57:39PM +0100, Bo Thorsen wrote:
> Hi Bo,
> I'd like to keep this method to have an additional abstraction layer to
> add new config items. Cornelius?
In what way to add? This is a virtual function right? So we want to force 
Resources to call the base class method so we can add config items there 
later? This sounds broken. In the case where we want/must to be called we 
should use other techniques.

> > - has default implementations of asyncLoad and asyncSave, since the
> > resource subclasses I've seen all have this exact implementation. Code
> > duplication is bad, so it might as well be in the superclass
> Holger suggested to do it the other way around. We should force to
> implement an asyncLoad/Save and give an default Implementation for
> syncLoad/Save which calls the async methods.
Anyway this is also an inprovement and might be more easy to implement in the 
first place. My idea was to use inheritance from either the Sync or ASYNC 
Resource interface...

Holger 'zecke' Freyther
Project OPIE- the Open Palmtop Integrated Environment | (german)
IRC: #opie

More information about the kde-core-devel mailing list