[patch] kioslave performance issues, dramatic improvement for ftp

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed February 11 2004 13:22, Stephan Kulow wrote:
> On Wednesday 11 February 2004 12:25, Dr. Juergen Pfennig wrote:
> >    Except "file" no kio slave seems to implement the "copy" method. The
> > "ftp" slave contained the comment "as far as I know this is not
> > implemented". But it is (see patch) and it works!
>
> The copy method is also used for inter-protocol copies and you break that
> in your patch. So technically you have to return ERR_NOT_SUPPORTED when the
> dest.protocol() is != file.

I think it is only called for ftp-to-ftp copies, but since that is indeed not 
handled, it should return ERR_NOT_SUPPORTED in that case.

> Otherwise the patch should be fine and I guess, you're right that we should
> move some of this in the framework to make copyToFile available to sftp,
> fish, smb, etc.

Yup. 

As far as the patch goes, I don't think the blocksize needs to start small 
btw. The read will return a smaller block AFAIK if only a small amount of 
data is available at a given time.

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFAKinoN4pvrENfboIRAiEJAJ4uBw7brlpT6t3Qdte0Z3HFglJhwwCdEa3w
SeFuPIPzxYYEcWbPuKOiWzA=
=oubX
-----END PGP SIGNATURE-----