Support in KToggleAction for toggling the text itself

[Gérard Delafond]

I am very happy David agrees with my opinion and started working on this.

1) At his moment, KDE is inconsistent :
-some programs show "Start/Stop" (Horrible)
-some others "(x) Start" (most of them)
-some others "Start" when it is stopped, and "Stop" when it is started (Eg : 
KStars)

2) I think the (x) shows a misunderstanding of what a menu item is for.
IMHO, a menuitem is for acting, not for getting information. the information 
should be for example in the status bar.
If you use a Toggle menu, it is harder to know the status of the item (you 
must say "if it says "Start", it means that it is stopped").
But toggle menus are easiear to understand for acting. I want to start, I 
click on "Start". I want to stop, I click on "Stop".

Examples:                    Should be
Kpat
Settings
->Animation               Avtivate - Deactivate
->Automatic moves     Activate - Deactivate

KPresenter
Display
->Display sidebar        Display- Hide
->Display Notebar       Display- Hide
->Front Grid               Front - Back 
->Stick to Grid             Stick - Do not stick
Text
->Activate Autospell    Activate - Deactivate

Kate
Display
->Several items

Kalzium
Display
->Several items

Gerard

Le vendredi 06 Février 2004 18:05, David Faure a écrit :
> The problem:
> --------------
> Toggle actions plugged into menus currently toggle a checkmark in front of
> the menu item. This is typically used with a text that represents a state
> (e.g. "View/Frame Borders").
>
> But this is usually ambiguous (if I see "Case Insensitive Sort" in a menu,
> does that mean it's currently sorting that way or that one should click on
> it to sort that way?).
>
> Better is to use verbs, to describe actions. We do so already for e.g.
> "Show menubar". However this is even worse currently: when the menubar is
> shown, the menuitem still says "show menubar", which is a really wrong text
> for a menuitem hiding it.
>
> The solution:
> --------------
> The attached patch adds support for (optionally) toggling the text instead
> of using a checkmark for toggleactions in menuitems, and uses this support
> for the show/hide menubar and toolbar actions.
>
> I hesitated to subclass KToggleAction for it, but that means copying
> thousands (almost) of constructors :). So I preferred to add a setting to
> KToggleAction.
>
> OK to commit?