Support in KToggleAction for toggling the text itself

[David Faure]

On Friday 06 February 2004 19:17, Olivier Goffart wrote:
> Le Vendredi 6 Février 2004 18:05, David Faure a écrit :
> > OK to commit?
> 
> I just looked the patch...
> I'm maybe wrong, but i get some thought.
> Shouldn't setCheckedText call something like updateText()
updateText sounds like a verb ("update the text right now") - which isn't what it does,
it's about storing the text that will be used when the action is checked.

> And if for a reason or another setText is called while the action is checked, 
> the new text will be placed in place of the checked one.
> Now, you could argue that setText and setCheckedText shouldn't be called after 
> the creation of the action.
Hum, yes, the whole point is to let KToggleAction handle the setting of the
text.... Any setText call will be reverted at some point anyway, when that feature
is used, when toggling/untoggling the action... Automatic and manual modes
never go well together...

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).