[PATCH] KEditToolBar inserts invisible line separator

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue April 6 2004 20:40, Jeroen Wijnhout wrote:
> Hi,
>
> Maybe it's just me, but the KEditToolBar widget has a little bug. When
> inserting a separator in a toolbar ("-----"), the following line is written
> to the ui.rc file:
>
> <Separator name="Separator_0" />
>
> This misses the lineSeparator attribute set to "true", resulting in an
> invisible separator.  At first I thought the separator wasn't present at
> all, but the distance between the two adjacent toolbar button is slightly
> increased.
>
> At least to me, a separator visualized as "------" should be a _visible_
> separator.
>
> This little patch fixes this bug. The patch is against the stable branch
> (KDE_3_2_BRANCH). Please review.

I think the toolbar editor should keep track of visible and invisible 
separators separately, I suspect that this patch turns invisible separators 
into visible ones, once you edit something. KDE applications seem to come 
with invisible ones by default.

Cheers,
Waldo
- -- 
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
^ bastian at kde.org | Is your software SUSE LINUX READY? | bastian at suse.com
^<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFAcxpcN4pvrENfboIRAqVcAJ9/TA6Zvuvxq9OREhincdinHtAedQCfRxZq
Ph5UNBKEnVsIjPyfBVuBDoc=
=9o4M
-----END PGP SIGNATURE-----