[PATCH] KEditToolBar inserts invisible line separator

[Sandro Giessl]

Am Tuesday 06 April 2004 23:00 schrieb Waldo Bastian:
> On Tue April 6 2004 20:40, Jeroen Wijnhout wrote:
> > Hi,
> >
> > Maybe it's just me, but the KEditToolBar widget has a little bug.
> > When inserting a separator in a toolbar ("-----"), the following
> > line is written to the ui.rc file:
> >
> > <Separator name="Separator_0" />
> >
> > This misses the lineSeparator attribute set to "true", resulting in
> > an invisible separator.  At first I thought the separator wasn't
> > present at all, but the distance between the two adjacent toolbar
> > button is slightly increased.
> >
> > At least to me, a separator visualized as "------" should be a
> > _visible_ separator.
> >
> > This little patch fixes this bug. The patch is against the stable
> > branch (KDE_3_2_BRANCH). Please review.
>
> I think the toolbar editor should keep track of visible and invisible
> separators separately, I suspect that this patch turns invisible
> separators into visible ones, once you edit something. KDE
> applications seem to come with invisible ones by default.
Some time ago, had the same idea and I have a quick&dirty patch for it 
lying around. ;)
My plan was to clean the whole class a bit up but I didn't have the time 
yet, so it may be a good idea to just commit it for now...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kedittoolbar_linesep.diff
Type: text/x-diff
Size: 3025 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040407/7ab4402b/attachment.diff>