PATCH: Make KShortcutMenu pass Enter, Return to QPopupMenu (#55139)

Aaron J. Seigo aseigo at
Tue May 13 19:36:36 BST 2003

Hash: SHA1

On Monday 12 May 2003 09:03, Maks Orlovich wrote:
> On Wednesday 30 April 2003 11:53 pm, Maks Orlovich wrote:
> > Hi...
> >
> > Currently, in case of an accel conflict, we popup a very nice menu
> > letting the user make a choice between the two options.. The menu is also
> > navigable with keyboard -- except, as #55139 points out, one can't
> > actually activate an item like that, since KShortcutMenu intercepts enter
> > (and most other keys) and calls close().
> >
> > The attached patch fixes that; please review.
> ping. If no one responds within a week, I think I'll have to commit -- I
> don't think that we can let bugs go unfixed because no-one reviews a nearly
> trivial patch that was posted 'just-in-case' :-(

sorry, i've been stupidly busy =(  ok, now that my lame excuse is out of the 
way, on to the patch ;-)

the patch looks good and indeed fixes a very annoying behaviour that i hadn't 
run in to until just now when verifying the bug your patch fixes...

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE: The 'K' is for 'kick ass'
Version: GnuPG v1.0.7 (GNU/Linux)


More information about the kde-core-devel mailing list