[PATCH] Fix 20522 - kedittoolbar does not handle iconsets

Stephan Kulow coolo at kde.org
Wed Mar 12 11:12:17 GMT 2003

Am Wednesday 12 March 2003 01:18 schrieb Ravikiran Rajagopal:
> Hello,
>   KGuiItem can have either an icon or an iconset. If it has one, it returns
> true on hasIcon(). However, its icon() method returns an empty string if it
> contains only an iconset. This means that KEditToolbar does not show an
> associated icon. (The bug reporter's patch does not work any longer as too
> many things have changed in the last 2 years.) The follwing patch fixes it.
> Ok to commit? Should (nearly trivial) patches like this be submitted for
> review?
They are - as kde-cvs would include the diff in the commit log. So feel free to
just commit your bug fixes and get them reverted when they are wrong :)

Greetings, Stephan

More information about the kde-core-devel mailing list