[PATCH] Fix 20522 - kedittoolbar does not handle iconsets
dfaure at klaralvdalens-datakonsult.se
Wed Mar 12 10:38:35 GMT 2003
-----BEGIN PGP SIGNED MESSAGE-----
On Wednesday 12 March 2003 01:18, Ravikiran Rajagopal wrote:
> KGuiItem can have either an icon or an iconset. If it has one, it returns
> true on hasIcon(). However, its icon() method returns an empty string if it
> contains only an iconset. This means that KEditToolbar does not show an
> associated icon. (The bug reporter's patch does not work any longer as too
> many things have changed in the last 2 years.) The follwing patch fixes it.
> Ok to commit?
Looks fine to me, please commit.
> Should (nearly trivial) patches like this be submitted for review?
Maybe this one didn't need review. But as soon as you are not 150% sure
about a patch, better post it here ;)
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Klarälvdalens Datakonsult AB, Platform-independent software solutions
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the kde-core-devel