KDialogBase patch - make the first widget initially focused

Lubos Lunak l.lunak at suse.cz
Mon Jan 27 16:35:31 GMT 2003

On Monday 27 of January 2003 13:44, Lubos Lunak wrote:
>  Hello,
>  could somebody please review the attached patch? I use KDialogBase for my
> dialogs, and all of them have initially focus on the Ok button instead on
> the first widget in the dialog, which I find really annoying (yes, I know,
> I could call explictly setFocus() everywhere, but why?). You can for
> example see this with 'kcmshell email'.
>  I figured KDialogBase is even explicitly forcing focus on the button for
> some strange reason (strange, because Enter or at least Ctrl+Enter
> activates that button anyway). This patch both disables this explicit
> giving of the focus to the button, and also reorders all buttons in the
> dialog to be at the end of the tab order. Does somebody know why
> KDialogBase was written this way, or is it ok to commit the patch?

 Bah, forget it for now, it needs some more fixing. Focused labels are funny, 
but I think that preferably shouldn't happen.

Lubos Lunak
KDE developer
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/

More information about the kde-core-devel mailing list