KDialogBase patch - make the first widget initially focused

Lubos Lunak l.lunak at suse.cz
Mon Jan 27 12:44:33 GMT 2003


 could somebody please review the attached patch? I use KDialogBase for my 
dialogs, and all of them have initially focus on the Ok button instead on the 
first widget in the dialog, which I find really annoying (yes, I know, I 
could call explictly setFocus() everywhere, but why?). You can for example 
see this with 'kcmshell email'.

 I figured KDialogBase is even explicitly forcing focus on the button for some 
strange reason (strange, because Enter or at least Ctrl+Enter activates that 
button anyway). This patch both disables this explicit giving of the focus to 
the button, and also reorders all buttons in the dialog to be at the end of 
the tab order. Does somebody know why KDialogBase was written this way, or is 
it ok to commit the patch?

Lubos Lunak
KDE developer
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdialogbase.cpp.patch
Type: text/x-diff
Size: 1157 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030127/3fc52c41/attachment.patch>

More information about the kde-core-devel mailing list