[PATCH] kdemultimedia/kioslave/audiocd

[André Wöbbeking]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 15 December 2003 22:07, David Faure wrote:
> On Monday 15 December 2003 20:05, André Wöbbeking wrote:
> > On Monday 15 December 2003 10:15, David Faure wrote:
> > > On Sunday 14 December 2003 14:44, André Wöbbeking wrote:
> > > >  atom.m_str = url.fileName().replace('/', QFL1("%2F"));
> > >
> > > This is wrong, it'll miss encoding % itself - this should use
> > > KIO::encodeFileName.
> >
> > I only replaced filename() with fileName(). Why must % be encoded,
> > for KUrl magic?
>
> No, to differenciate %2F (for slash) with %2F (as an actual part of
> the filename). KIO::encodeFileName turns % into %%.

Sure :) Next time I'll try to use my brain before asking for obvious 
things ;-)

> > > IMHO using a kapp in a slave is asking for trouble too - any
> > > chance libkcddb can avoid using the kapp pointer?
> >
> > The only way would be not to use ioslaves (as I wrote in my last
> > eMail kio::Job ctor calls kapp->ref(), ...).
>
> So you have a kioslave that uses a kioslave, indirectly?? Wow. I
> didn't even know this worked :)

Why not, otherwise you have to implement i.e. HTTP::get() by your own.

Is kapp->ref() & Co in kio::Job really needed?


André
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/3ikOGcp/AjG8ndYRArEFAJ49RaJExapRp1CnEZeSvbufXYwTrwCfQjZH
lysRl9qkkAaXgELsfiB4C50=
=vgNU
-----END PGP SIGNATURE-----