[PATCH] kdemultimedia/kioslave/audiocd

David Faure dfaure at klaralvdalens-datakonsult.se
Mon Dec 15 22:42:43 GMT 2003


On Monday 15 December 2003 22:35, André Wöbbeking wrote:
> Is kapp->ref() & Co in kio::Job really needed?

Yes, but not when it's called from a kioslave, so "if(kapp) kapp->ref()" should be fine. 

What's &Co? Ah, kapp->authorizeAction. I'll have to let Waldo answer that one:
is it ok to bypass kapp->authorizeAction from kioslaves? Should they then assume
"all allowed" or "all forbidden"? Should maybe authorizeAction be moved to another
class?
OTOH if it works to have a kapp in a slave, no problem. The reason we did 
without kapp in the first place is simply that it wasn't needed, so it was more
lightweight to do without.

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions




More information about the kde-core-devel mailing list