[PATCH] kdemultimedia/kioslave/audiocd

[David Faure]

On Monday 15 December 2003 20:05, André Wöbbeking wrote:
> On Monday 15 December 2003 10:15, David Faure wrote:
> > On Sunday 14 December 2003 14:44, André Wöbbeking wrote:
> > >  atom.m_str = url.fileName().replace('/', QFL1("%2F"));
> >
> > This is wrong, it'll miss encoding % itself - this should use
> > KIO::encodeFileName.
> 
> I only replaced filename() with fileName(). Why must % be encoded, for
> KUrl magic?

No, to differenciate %2F (for slash) with %2F (as an actual part of the filename).
KIO::encodeFileName turns % into %%.

> > IMHO using a kapp in a slave is asking for trouble too - any chance
> > libkcddb can avoid using the kapp pointer?
> 
> The only way would be not to use ioslaves (as I wrote in my last eMail
> kio::Job ctor calls kapp->ref(), ...).

So you have a kioslave that uses a kioslave, indirectly?? Wow. I didn't even
know this worked :)

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions