[PATCH] kdemultimedia/kioslave/audiocd
André Wöbbeking
Woebbeking at onlinehome.de
Mon Dec 15 19:05:07 GMT 2003
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Monday 15 December 2003 10:15, David Faure wrote:
> On Sunday 14 December 2003 14:44, André Wöbbeking wrote:
> > atom.m_str = url.fileName().replace('/', QFL1("%2F"));
>
> This is wrong, it'll miss encoding % itself - this should use
> KIO::encodeFileName.
I only replaced filename() with fileName(). Why must % be encoded, for
KUrl magic?
> IMHO using a kapp in a slave is asking for trouble too - any chance
> libkcddb can avoid using the kapp pointer?
The only way would be not to use ioslaves (as I wrote in my last eMail
kio::Job ctor calls kapp->ref(), ...).
André
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQE/3gXpGcp/AjG8ndYRAtjVAJ9/frpyjpp6giPPQ54qbnecL+/8MQCfdtli
e4c9dwkPQoLS7YUjB/LIiWU=
=1pLJ
-----END PGP SIGNATURE-----
More information about the kde-core-devel
mailing list