[PATCH] Re: Style names

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue December 02 2003 15:14, Maks Orlovich wrote:
> > The attached patch:
> > * fixes translations by actually showing the translated name in the
> > combobox instead of the internal id.
>
> I think this is a little easier if one keeps a reverse name->id mapping,
> and drops the currentStyle string entirely, since it always mirrors the
> combo. There is an another problem with the current kcm, BTW: it doesn't
> show up installed styles w/o .themerc files, which can hurt compatibility
> with some 3rd-party ones. The attached is my try at that...

Looks good.

> It doesn't try 
> to preserve any hidden styles, though, as I don't believe we should be
> hiding either B3 or Light2.

I fail to see the point in shipping styles with 3 different pixels. It's like 
shipping KMailV2 in addition to KMail because I disagree with the layout of 
the folder-list.

Can they at least get a decent name then?

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/zKCON4pvrENfboIRAu1uAJ9UQYsYffGHgF+kmvmBwS/IZrdbLQCfYiaZ
F/86csQVeViM7TFkIHCWJwc=
=kcet
-----END PGP SIGNATURE-----