_BRANCH Konsole & FreeBSD

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 24 August 2003 23:56, Adriaan de Groot wrote:
> Many moons ago, I wrote patches to get konsole to work around many
> linuxistic assumptions and actually invoke konsole_grantpty properly;
> recent changes in -CURRENT that break konsole wrt. gethostname() reminded
> me that I still haven't committed them nor ported them to HEAD. Find
> attached a patch:
>
> * Makes the FD that konsole_grantpty uses a parameter. To be sure, I can't
> tell what the security implications of this change might be. I can imagine
>
> 	konsole_grantpty --revoke 3> /tmp/bar
>
> actually already as a way to mess with /tmp/bar (well, if it was a tty).
>
> To be on the safe side, konsole_grantpty should still work with FD 3 if no
> extra parameter is given. This allows the patched konsole_grantpty to work
> with older konsole's. Might be overkill, though.

TEPtyInit() seems redundant. If you pass the fd-number via the command line 
you can leave out the dup2(fd,3) call and just pass "fd" via the command 
line, no?

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/TLOsN4pvrENfboIRAiQXAJ9S4GuBdvrG8hpqfiTF5tpe8LTFywCfRb68
G6g+19gcjAhwwrLMi/1+Ju4=
=KAGj
-----END PGP SIGNATURE-----