_BRANCH Konsole & FreeBSD

Adriaan de Groot adridg at cs.kun.nl
Sun Aug 24 22:56:59 BST 2003

Many moons ago, I wrote patches to get konsole to work around many linuxistic 
assumptions and actually invoke konsole_grantpty properly; recent changes in 
-CURRENT that break konsole wrt. gethostname() reminded me that I still 
haven't committed them nor ported them to HEAD. Find attached a patch:

* Makes the FD that konsole_grantpty uses a parameter. To be sure, I can't 
tell what the security implications of this change might be. I can imagine

	konsole_grantpty --revoke 3> /tmp/bar

actually already as a way to mess with /tmp/bar (well, if it was a tty).

To be on the safe side, konsole_grantpty should still work with FD 3 if no 
extra parameter is given. This allows the patched konsole_grantpty to work 
with older konsole's. Might be overkill, though.

* gethostname() may also return ENAMETOOLONG.

* ttyname() only works on ttys, not ptys in FreeBSD.

* Use Q_OS_FREEBSD instead of __FreeBSD__.

OK to apply? Look sensible for HEAD as well?

pub  1024D/FEA2A3FE 2002-06-18 Adriaan de Groot <groot at kde.org>
     Key fingerprint = 934E 31AA 80A7 723F 54F9  50ED 76AC EE01 FEA2 A3FE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konsole.diff
Type: text/x-diff
Size: 8599 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030824/2326caca/attachment.diff>

More information about the kde-core-devel mailing list