KDEPrint code cleanup
wheeler at kde.org
Fri Aug 1 14:48:07 BST 2003
On Friday 01 August 2003 15:06, Michael Goffioul wrote:
> There were BIC changes to those internal headers in the past (with
> agreement of other core developers who noticed it), but OK they were
> not tagged as internal, I shouldn't, I won't. Next KDEPrint
> improvement will be for 4.0.
Ok, just did some diffing and yeah, it doesn't look like BC is salvageable at
this point. This is a bad thing, but I guess given the current situation it
really doesn't make a difference if there are further BC changes.
So -- a couple of notes:
There are some BIC changes in the "public" headers -- namely in KPrinter:
- QSize realPageSize() const;
+ DrPageSize* realPageSize() const;
- void setRealPageSize(QSize p);
+ void setRealPageSize(DrPageSize* p);
-QSize rangeToSize(const QString& s);
Also number two moves the method from public to protected, which is source
And *PLEASE* people, mark your installed internal headers as private. Not
just in kdelibs, but I've seen similar problems elsewhere in KDE (and whined
about them then too). In this case can you mark all of these as internal in
HEAD and BRANCH -- hopefully to prevent future confusion...
I mean, if 10 years from now, when you are doing something quick and dirty,
you suddenly visualize that I am looking over your shoulders and say to
yourself, "Dijkstra would not have liked this", well that would be enough
immortality for me.
-E. W. Dijkstra
More information about the kde-core-devel