ksystemtray context menu actions

Aaron J. Seigo aseigo at olympusproject.org
Thu Sep 26 20:47:14 BST 2002

Hash: SHA1


ksystemtray puts two items in its menu: quit  and restore/minimize ... 
however, since they are manually inserted the only way for subclasses to 
access these items is to perform ugly hacks like iterating through the menu 
and comparing the text used... kmix was doing this, for instance, to find the 
quit item.

attached is a patch that changes ksystemtray to use kactions and keep them in 
an action collection. this allows easy and standard access to the items it 
adds and allows for future flexibility.

i'd like to commit this for 3.1 to address a usability issue identified with 
the kmix system tray icon: users don't connect "restore" with "open up the 
mixer window". attached is a patch that shows how, with kactions, this would 
be easily addressed.

is this ok to commit?

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

"Everything should be made as simple as possible, but not simpler"
    - Albert Einstein
Version: GnuPG v1.0.7 (GNU/Linux)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ksystray_actions.diff
Type: text/x-diff
Size: 4469 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020926/e5bc12a3/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmix_systrayactions.diff
Type: text/x-diff
Size: 1046 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020926/e5bc12a3/attachment-0001.diff>

More information about the kde-core-devel mailing list