QDateTime and kdbgstream

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 12 November 2002 11:47, Holger Freyther wrote:
> Hi devels,
> I would like to commit the following patch after KDE3.1 was released.
> It adds 3 operator<<'s. One for QDateTime, one for QTime and one for QDate.

Looks good. This makes me wonder why kdebugclasses.h is all inlined.
I mean, with your approach, only forward declarations are needed in the .h file,
so it's indeed no problem to add some more types to kdebug.h
With kdebugclasses.h, the calling code has to include all those additional headers.
Why don't we use this approach (non-inline methods) for all the types handled
by kdebugclasses.h? Then we could move all those to kdebug.h, since it
would involve no #include cost. (Who cares about runtime costs, for a kdDebug
statement?)
Ah BTW your patch misses empty inline versions for kndbgstream (the --disable-debug case).

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE90N9+72KcVAmwbhARAkn4AKCfYzAWfZ73Holh/nFAhh9ylOIVWgCdFBMF
XK70U9No9U7sHYXGaIpVkW8=
=7CXO
-----END PGP SIGNATURE-----