[kde-community] What is a GitHub pull request exactly?

Martin Klapetek martin.klapetek at gmail.com
Sat Sep 19 16:26:34 UTC 2015


On Sat, Sep 19, 2015 at 12:07 PM, Boudhayan Gupta <bgupta at kde.org> wrote:

> On 19 September 2015 at 21:17, Martin Graesslin <mgraesslin at kde.org>
> wrote:
> > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote:
> >> If the problem is somewhere in (a), where is it?
> >
> > I'm afraid of code review happening through the pull request instead of
> our
> > infrastructure. To me github pull requests are not just the "here's the
> > patch", but also the code review.
>
> This.
>
> The other problem is that the PR submitter may not have a KDE
> identity, in which case we have no way of representing the fellow and
> properly crediting the commit to him/her. We have to explicitly
> redirect him to KDE's infrastructure for this.
>

That is not true. You can credit any commit to anyone

git commit --author "My Name <myemail at hello.org>"

which is a standard practice around KDE, when committing patches
on behalf of newcomers who don't have write access.

Cheers
-- 
Martin Klapetek | KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-community/attachments/20150919/483caced/attachment.html>


More information about the kde-community mailing list