[kde-community] What is a GitHub pull request exactly?

Martin Graesslin mgraesslin at kde.org
Sat Sep 19 16:32:07 UTC 2015


On Saturday, September 19, 2015 12:26:34 PM CEST Martin Klapetek wrote:
> On Sat, Sep 19, 2015 at 12:07 PM, Boudhayan Gupta <bgupta at kde.org> wrote:
> > On 19 September 2015 at 21:17, Martin Graesslin <mgraesslin at kde.org>
> > 
> > wrote:
> > > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote:
> > >> If the problem is somewhere in (a), where is it?
> > > 
> > > I'm afraid of code review happening through the pull request instead of
> > 
> > our
> > 
> > > infrastructure. To me github pull requests are not just the "here's the
> > > patch", but also the code review.
> > 
> > This.
> > 
> > The other problem is that the PR submitter may not have a KDE
> > identity, in which case we have no way of representing the fellow and
> > properly crediting the commit to him/her. We have to explicitly
> > redirect him to KDE's infrastructure for this.
> 
> That is not true. You can credit any commit to anyone
> 
> git commit --author "My Name <myemail at hello.org>"
> 
> which is a standard practice around KDE, when committing patches
> on behalf of newcomers who don't have write access.

In addition a nicely put commit through git format-patch and be applied 
through git am and then pushed with correct authorship.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-community/attachments/20150919/ea8c5a9f/attachment.sig>


More information about the kde-community mailing list