[kde-community] What is a GitHub pull request exactly?

Boudhayan Gupta bgupta at kde.org
Sat Sep 19 16:07:43 UTC 2015


On 19 September 2015 at 21:17, Martin Graesslin <mgraesslin at kde.org> wrote:
> On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote:
>> If the problem is somewhere in (a), where is it?
>
> I'm afraid of code review happening through the pull request instead of our
> infrastructure. To me github pull requests are not just the "here's the
> patch", but also the code review.

This.

The other problem is that the PR submitter may not have a KDE
identity, in which case we have no way of representing the fellow and
properly crediting the commit to him/her. We have to explicitly
redirect him to KDE's infrastructure for this.



More information about the kde-community mailing list