D22699: Support passing target to ecm_qt_declare_logging_category

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> ECMQtDeclareLoggingCategory.cmake:133
> +    if(TARGET ${sources_var})
> +        cmake_minimum_required(VERSION 3.1)
> +        target_sources(${sources_var} PRIVATE ${cpp_filename})

-1 for changing the minimum CMake version in a macro. The change must be compatible the project requirement.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190724/7614c6e3/attachment.html>