<table><tr><td style="">cgiboudeaux added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22699">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22699#inline-128158">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ECMQtDeclareLoggingCategory.cmake:133</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">set</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">sources</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"${</span>${sources_var}<span class="bright">}"</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">list</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">APPEND</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">sources</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"${cpp_filename}"</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">set</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span style="color: #001294">sources<span class="bright">_var</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"</span>${sources<span class="bright">}"</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">PARENT_SCOPE</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">TARGET</span></span><span class="bright"> </span><span style="color: #aa2211">${</span><span style="color: #001294">sources_var</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright">    </span><span style="color: #304a96"><span class="bright">cmake_minimum_required</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">VERSION</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">3.1</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright">    </span><span style="color: #304a96"><span class="bright">target_</span>sources<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #aa2211">${</span><span style="color: #001294">sources<span class="bright">_var</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">PRIVATE</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">cpp_filename</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">-1 for changing the minimum CMake version in a macro. The change must be compatible the project requirement.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22699">https://phabricator.kde.org/D22699</a></div></div><br /><div><strong>To: </strong>daandemeyer, alexmerry<br /><strong>Cc: </strong>cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns<br /></div>