<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129763/">https://git.reviewboard.kde.org/r/129763/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Shaheed Haque.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The change broke the integration with the bulk testing tools, these
will be restored in a subsequent commit.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Re-install and then re-run kguiaddons:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ sudo make install
[sudo] password for srhaque:
...
-- Installing: /usr/local/share/ECM/find-modules/FindPythonModuleGeneration.cmake
...
-- Installing: /usr/local/share/ECM/find-modules/sip_generator.py</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ make
...
[ 1%] Generating sip/PyKF5/KGuiAddons/kcolorutils.sip
[ 3%] Generating sip/PyKF5/KGuiAddons/kcolorcollection.sip
[ 5%] Generating sip/PyKF5/KGuiAddons/kcolormimedata.sip
[ 7%] Generating sip/PyKF5/KGuiAddons/kdatevalidator.sip
[ 8%] Generating sip/PyKF5/KGuiAddons/kwordwrap.sip
[ 10%] Generating sip/PyKF5/KGuiAddons/kfontutils.sip
[ 12%] Generating sip/PyKF5/KGuiAddons/kiconutils.sip
[ 14%] Generating sip/PyKF5/KGuiAddons/kimagecache.sip
[ 16%] Generating sip/PyKF5/KGuiAddons/kmodifierkeyinfo.sip
[ 16%] Built target generate_KGuiAddons_sip_files
[ 17%] Generating pybuild/PyKF5/KGuiAddons/unifiedKGuiAddons.cpp
...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ ctest
Test project /home/srhaque/kdebuild/kguiaddons
Start 1: appstreamtest
1/6 Test #1: appstreamtest .................... Passed 0.02 sec
Start 2: Py3Test
2/6 Test #2: Py3Test .......................... Passed 0.14 sec
Start 3: Py2Test
3/6 Test #3: Py2Test .......................... Passed 0.11 sec
Start 4: kwordwraptest
4/6 Test #4: kwordwraptest .................... Passed 0.16 sec
Start 5: kcolorutilstest
5/6 Test #5: kcolorutilstest .................. Passed 0.53 sec
Start 6: kiconutilstest
6/6 Test #6: kiconutilstest ................... Passed 0.08 sec</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">100% tests passed, 0 tests failed out of 6</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Total Test time (real) = 1.04 sec</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindPythonModuleGeneration.cmake <span style="color: grey">(0a857a24b17d74ae34d2ca8062a274778895b2c2)</span></li>
<li>find-modules/sip_generator.py <span style="color: grey">(10be147711540437d38153fa8fe859bd34d7aa6c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129763/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>