D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Dec 12 16:22:04 UTC 2017


apol added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in KDEInstallDirs.cmake:700-704
> missing LD_LIBRARY_PATH ?

Usually isn't necessary as you get the libraries through the rpath. I can add it though.

> cgiboudeaux wrote in KDEInstallDirs.cmake:707
> I'm not sure that's the right location. my installation prefixes only contains subdirectories.
> This file will also be overwritten if several modules turn the option on (which is an issue for distributions if they decide to enable the feature)

I wouldn't expect distros to pick this up, distros usually operate exclusively on /usr. If for some reason they did, they can always get this file in from a separate package that only installs this file.

It's the right location though, because all projects in the same prefix will need this variables in the same way.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9299

To: apol, #frameworks
Cc: cgiboudeaux, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20171212/4eb3aeda/attachment.html>


More information about the Kde-buildsystem mailing list