<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9299" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9299#inline-42058" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cgiboudeaux</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KDEInstallDirs.cmake:700-704</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">missing LD_LIBRARY_PATH ?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Usually isn't necessary as you get the libraries through the rpath. I can add it though.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9299#inline-42062" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cgiboudeaux</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KDEInstallDirs.cmake:707</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I'm not sure that's the right location. my installation prefixes only contains subdirectories.<br />
This file will also be overwritten if several modules turn the option on (which is an issue for distributions if they decide to enable the feature)</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wouldn't expect distros to pick this up, distros usually operate exclusively on /usr. If for some reason they did, they can always get this file in from a separate package that only installs this file.</p>
<p style="padding: 0; margin: 8px;">It's the right location though, because all projects in the same prefix will need this variables in the same way.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9299" rel="noreferrer">https://phabricator.kde.org/D9299</a></div></div><br /><div><strong>To: </strong>apol, Frameworks<br /><strong>Cc: </strong>cgiboudeaux, Build System<br /></div>