Review Request 128112: New module: ecm_win_resolve_symlinks

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128112/#review100590
-----------------------------------------------------------


Fix it, then Ship it!





modules/ECMWinResolveSymlinks.cmake (line 21)
<https://git.reviewboard.kde.org/r/128112/#comment67524>

    needs to be updated


- David Faure


On June 17, 2016, 8:32 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128112/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 8:32 a.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> When git is checking out repositories with UNIX symbolic links inside on Windows machine, it writes them as plain text files, containing relative path to the real file. This is the case for breeze-icons framework, for instance, and this breaks some icons that are symlinked.
> 
> This macro is intended to fix that. There is some room for performance improvement, but i wanted to get the feedback early.
> 
> 
> Diffs
> -----
> 
>   modules/ECMWinResolveSymlinks.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161105/8912c678/attachment.html>