Review Request 126368: Include <QDebug> with generated logging category file
Alex Merry
alex.merry at kde.org
Fri Dec 18 22:43:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126368/#review89727
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Dec. 18, 2015, 9:53 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126368/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 9:53 p.m.)
>
>
> Review request for Extra Cmake Modules.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> In order to use the logging categories created by ECM,
> the generated header file has to be included but then
> also #include <QDebug> must be added to make it usable
> at all for qCDebug/qCWarning stuff.
>
> So this puts the #include <QDebug> into the generated
> header file and thus allowing to include a single header
> for qCDebug/qCWarning instead of two.
>
>
> Diffs
> -----
>
> modules/ECMQtDeclareLoggingCategory.cmake b7f1ad3
> modules/ECMQtDeclareLoggingCategory.h.in fedecd2
>
> Diff: https://git.reviewboard.kde.org/r/126368/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151218/194c5957/attachment.html>
More information about the Kde-buildsystem
mailing list