Review Request 126368: Include <QDebug> with generated logging category file
Martin Klapetek
martin.klapetek at gmail.com
Fri Dec 18 21:53:10 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126368/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 10:53 p.m.)
Review request for Extra Cmake Modules.
Changes
-------
Add a mention to the docs
Repository: extra-cmake-modules
Description
-------
In order to use the logging categories created by ECM,
the generated header file has to be included but then
also #include <QDebug> must be added to make it usable
at all for qCDebug/qCWarning stuff.
So this puts the #include <QDebug> into the generated
header file and thus allowing to include a single header
for qCDebug/qCWarning instead of two.
Diffs (updated)
-----
modules/ECMQtDeclareLoggingCategory.cmake b7f1ad3
modules/ECMQtDeclareLoggingCategory.h.in fedecd2
Diff: https://git.reviewboard.kde.org/r/126368/diff/
Testing
-------
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151218/be4a47e9/attachment.html>
More information about the Kde-buildsystem
mailing list