Review Request 126368: Include <QDebug> with generated logging category file

Martin Klapetek martin.klapetek at gmail.com
Mon Dec 21 19:30:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126368/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 7:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules.


Changes
-------

Submitted with commit 1d4bc35cf9383177459544d6fcd9de35edf3e77d by Martin Klapetek to branch master.


Repository: extra-cmake-modules


Description
-------

In order to use the logging categories created by ECM,
the generated header file has to be included but then
also #include <QDebug> must be added to make it usable
at all for qCDebug/qCWarning stuff.

So this puts the #include <QDebug> into the generated
header file and thus allowing to include a single header
for qCDebug/qCWarning instead of two.


Diffs
-----

  modules/ECMQtDeclareLoggingCategory.cmake b7f1ad3 
  modules/ECMQtDeclareLoggingCategory.h.in fedecd2 

Diff: https://git.reviewboard.kde.org/r/126368/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151221/e0d3012f/attachment.html>


More information about the Kde-buildsystem mailing list