[PATCH 2/3] Do not add some unneeded linker flags when on BSD.

[Alexander Neundorf]

On Monday 23 July 2012, Raphael Kubo da Costa wrote:
> It is not clear why -lc needed to be passed. It seems to have come
> with commit 4d1789f40ed1cc6e34e55b9edc119ee6389e1368, but things seem
> to work just fine without that on FreeBSD.
> 
> Also remove the _GNU_SOURCE definition, as that is only needed by
> glibc (see feature_test_macros(7) on Linux).

You can probably judge on this much better than I can. In the early KDE4 days 
I was building kdelibs also on FreeBSD, and maybe some of those things still 
come from that time and were necessary back then.

Could they maybe be necessary for older versions of FreeBSD ?

Alex


> ---
>  cmake/modules/FindKDE4Internal.cmake | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/cmake/modules/FindKDE4Internal.cmake
> b/cmake/modules/FindKDE4Internal.cmake index 0a1a3e8..6822b02 100644
> --- a/cmake/modules/FindKDE4Internal.cmake
> +++ b/cmake/modules/FindKDE4Internal.cmake
> @@ -1135,12 +1135,6 @@ if (UNIX)
>     endif (NOT _OFFT_IS_64BIT)
>  endif (UNIX)
> 
> -if (CMAKE_SYSTEM_NAME MATCHES BSD)
> -   set ( _KDE4_PLATFORM_DEFINITIONS -D_GNU_SOURCE )
> -   set ( CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -lc")
> -   set ( CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -lc")
> -endif (CMAKE_SYSTEM_NAME MATCHES BSD)
> -
> 
>  ############################################################
>  # compiler specific settings

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120727/7eb0a6b9/attachment-0001.html>