[PATCH 3/3] Group all scattered compiler settings.

[Alexander Neundorf]

On Friday 27 July 2012, Raphael Kubo da Costa wrote:
> Alexander Neundorf <neundorf at kde.org> writes:
> > On Monday 23 July 2012, Raphael Kubo da Costa wrote:
> >> No functional changes: simply put all compiler-related changes in
> >> a single block to ease maintenance, and add some comments to explain
> >> why some calls are made.
> > 
> > Are you sure about them, also e.g. on OSX ?
> > If so, go ahead.
> 
> Unfortunately, I don't have access to an OS X machine to test these
> changes. If I wrote the patch correctly, there should be no changes to
> Mac at all, as the code was just moved from one block for (Linux/Hurd &&
> gcc/icc) to another.
> 
> > Also, can you please commit those changes also to kde-
> > modules/KDECompilerSettings.cmake in the (new) extra-cmake-modules git
> > repository ?
> 
> Given the above, do you think it's safer to commit this patch only to
> e-c-m and leave kdelibs unchanged?

If you commit it, I'd prefer if you commit it to both.

I think I also moved the stuff a bit around already in e-c-m, so it may be a 
bit different there.

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120728/aaad6f98/attachment.html>