Review Request: Fix Phonon lookup when compiling KDELibs

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102681/
-----------------------------------------------------------

Review request for Build System and Alexander Neundorf.


Summary
-------

I have two Phonon installs: Archlinux's in /usr and mine in a home directory.

The problem was that all the modules found the correct Phonon install but KDELibs, because KDE4_LIB_INSTALL_DIR was not yet defined when calling find_package(Phonon ...). This lead to a buggy KDELibs4LibraryTargets-debugfull.cmake file that was pointing to /usr/lib/libphonon.so in some targets, thus making it impossible to compile some applications that depend on it.

This patch delays the Phonon lookup until we have the LIB_INSTALL_DIR variable defined and, in case there isn't a KDE4_KDE4_LIB_INSTALL_DIR variable, it defines one (there can't be if there's no KDELibsDefinitions.cmake file yet, aka a bootstrapping KDELibs4Internal.cmake call).

I'm not sure it's the best approach but it's working here and I think that will be a good help, since I had this problem before and had to workaround it.

Hope this helps.


Diffs
-----

  cmake/modules/FindKDE4Internal.cmake ef705fb 
  cmake/modules/FindPhonon.cmake cd9e5cb 

Diff: http://git.reviewboard.kde.org/r/102681/diff


Testing
-------

Compiled both kdelibs and kde-runtime successfully.
(before it complained in kde-runtime/khelpcenter because KDE4__khtml implied the dependency to /usr/libphonon.so).


Thanks,

Aleix

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20110922/f561e6f9/attachment.html>